Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 304 status on ServerResponse when ETag/LastModified match [SPR-16348] #20895

Closed
spring-issuemaster opened this issue Jan 4, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 4, 2018

Nikola Kolosnjaji opened SPR-16348 and commented

When Controller returns 200 OK and Mono<ResponseEntity<String>> with Etag HTTP header, second GET will result in 304 HTTP status, if client sends correct If-None-Match HTTP header.
This is not the case when using functional Endpoints.

Same behaviour would be expected with WebFlux.fn and ServerResponse and using 'Cache-Control', 'ETag', and/or 'If-Modified-Since' HTTP headers
reference: https://docs.spring.io/spring/docs/current/spring-framework-reference/web.html#mvc-caching-etag-lastmodified

Attached sample which reproduce the problem with two endponts: /contoller & /handler


Affects: 5.0.2

Attachments:

Referenced from: commits c53c8bf

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 18, 2018

Arjen Poutsma commented

Fixed in c53c8bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.