Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMS Producers are cached even when the destination is a temporary queue causing a memory leak [SPR-16353] #20900

Closed
spring-issuemaster opened this issue Jan 5, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 5, 2018

Facundo Velazquez opened SPR-16353 and commented

Looking at the code, in CachingConnectionFactory class, I can see this fix was added some years ago for fixing the same case but on the consumer side.
However, Temporary queue producers are always cached.

This scenario was discovered in a request-response scenario which is causing a memory leak in the Mule ESB. At least from my perspective, it doesn't make sense, since temporary queues producers won't be used more than once.


Affects: 4.3.13, 5.0.2

Issue Links:

  • #20995 CachingConnectionFactory - Invalid session in session cache

Referenced from: commits 72590db, bf4cada

Backported to: 4.3.14

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 7, 2018

Juergen Hoeller commented

Indeed, we need to skip caching for temporary destinations with producers as well. Fixed for 5.0.3 now, and to be backported to 4.3.14.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 8, 2018

Facundo Velazquez commented

Hi Juergen Hoeller. Thank you very much for the fix!
Please let me know if you have an ETA for the 4.3.14 release.
Regards.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 8, 2018

Juergen Hoeller commented

Our current target dates are always up on the roadmap page: https://jira.spring.io/browse/SPR/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel

For 4.3.14, it's currently January 18th. It may move by a few days but it's definitely going out in January still.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 8, 2018

Facundo Velazquez commented

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.