Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getCallbacks(Class<?>) method of CglibAopProxy [SPR-16354] #20901

Open
spring-projects-issues opened this issue Jan 6, 2018 · 0 comments
Open
Labels
in: core status: waiting-for-triage

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 6, 2018

Robin Wang opened SPR-16354 and commented

CglibAopProxy#getCallbacks creates FixedChainStaticTargetInterceptor for all methods of a target that is static when the advice chain is frozen which is unnecessary for methods with no advice.
This is already mentioned in the TODO comment at line 329.
According to CglibAopProxy.ProxyCallbackFilter#accept, when advice chain is frozen, methods with no advice have no possibility to choose a FixedChainStaticTargetInterceptor as their interceptor.
So we can implement this optimization to improve memory efficiency.


Referenced from: pull request #1639

@spring-projects-issues spring-projects-issues added status: waiting-for-triage type: enhancement in: core and removed type: enhancement labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: waiting-for-triage
Projects
None yet
Development

No branches or pull requests

1 participant