Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null path after UriComponents.normalize() results in NullPointerException [SPR-16364] #20911

Closed
spring-projects-issues opened this issue Jan 11, 2018 · 1 comment
Assignees
Labels
in: web type: bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 11, 2018

cda opened SPR-16364 and commented

Test case:

UriComponents uri1 = UriComponentsBuilder.fromUriString( "http://test.com" ).build().normalize();
UriComponents uri2 = UriComponentsBuilder.fromUriString( "http://test.com/" ).build();
assert !uri1.equals( uri2 );

Throws:

java.lang.NullPointerException
	at org.springframework.web.util.HierarchicalUriComponents$FullPathComponent.equals(HierarchicalUriComponents.java:700)
	at org.springframework.web.util.HierarchicalUriComponents.equals(HierarchicalUriComponents.java:464)
...

Also, this code throws NullPointerException:

UriComponentsBuilder.fromUriString( "http://test.com" ).build().normalize().getPathSegments()

Affects: 4.3.12

Issue Links:

  • #20099 Introduce null-safety of Spring Framework API

Referenced from: commits 93f6458, f68fdd4

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 11, 2018

Juergen Hoeller commented

This seems to work fine in 5.0.x; I'll check 4.3.x tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: bug
Projects
None yet
Development

No branches or pull requests

2 participants