Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EclipseLink does not log SQL parameters when using showSql [SPR-16383] #20929

Closed
spring-issuemaster opened this issue Jan 16, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Jan 16, 2018

Timo Meinen opened SPR-16383 and commented

EclipseLinkJpaVendorAdapter sets the logging level of eclipselink.logging.level.sql to FINE when showSql is true.

As of EclipseLink 2.4.0 - Juno this is not sufficient to log SQL parameter binding. Additionally, eclipselink.logging.parameters must be enabled.

From EclipseLink Wiki:

The logging of SQL parameters can be enabled, or disabled through the following properties:
<property name="eclipselink.logging.level.sql" value="FINE"/>
<property name="eclipselink.logging.parameters" value="true"/>
Note: Setting eclipselink.logging.level to FINE is not sufficient (as of EclipseLink 2.4.0 - Juno), you have to set eclipselink.logging.level.sql to FINE.

Please see attached Github Pull Request.


Reference URL: #1644

Backported to: 4.3.14

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 16, 2018

Juergen Hoeller commented

Good catch! Merged for 5.0.3 now; to be backported to 4.3.14 ASAP.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 16, 2018

Timo Meinen commented

That was fast! Thanks for backporting, so that we can remove our custom workaround shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.