Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with JDK 10 [SPR-16390] #20936

Closed
spring-projects-issues opened this issue Jan 16, 2018 · 2 comments
Closed

Compatibility with JDK 10 [SPR-16390] #20936

spring-projects-issues opened this issue Jan 16, 2018 · 2 comments
Assignees
Labels
type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 16, 2018

Juergen Hoeller opened SPR-16390 and commented

JDK 10 is currently in early access, scheduled for GA in late March: http://openjdk.java.net/projects/jdk/10/

Our Spring Framework master build is known to be compatible with JDK 10 EA already. Let's double-check against JDK 10 GA for Spring Framework 5.0.5.


Issue Links:

  • #18941 Compatibility with JDK 9 GA ("depends on")
  • #20937 Compatibility with JDK 11 ("is depended on by")
  • #20945 Upgrade to Kotlin 1.3
  • #20944 Upgrade to ASM 6.2

Referenced from: commits 28ea718

0 votes, 5 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 5, 2018

Juergen Hoeller commented

The entire framework build passes fine against the JDK 10 release candidate (build 45), so let's mark this issue as resolved. On to JDK 11...

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Mar 31, 2018

Juergen Hoeller commented

With a few refined dependency declarations, the framework build allows for setting sourceCompatibility / targetCompatibility to 10 now. With the AspectJ compiler in spring-aspects fixed to source 1.8, the entire test suite passes... except for the EclipseLink tests in spring-orm which need to forced to target 1.8 for the time being if supposed to pass with general target 10.

That said, the standard framework build remains on source+target 1.8 and passes out of the box when run on JDK 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task
Projects
None yet
Development

No branches or pull requests

2 participants