Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with JDK 11 [SPR-16391] #20937

Closed
spring-issuemaster opened this issue Jan 16, 2018 · 2 comments

Comments

@spring-issuemaster
Copy link
Collaborator

commented Jan 16, 2018

Juergen Hoeller opened SPR-16391 and commented

JDK 11 is currently scheduled for September 2018. Not expecting any major changes beyond JDK 10 from our perspective, we should be able to fully support it in the 5.1 line already. Ideally our framework build would be able to run on JDK 8, 9, 10 as well as 11, even if our own test efforts will focus on JDK 8 and 11 (as the official long-term support branches) at that point.


Issue Links:

  • #18941 Compatibility with JDK 9 GA ("depends on")
  • #20936 Compatibility with JDK 10 ("depends on")
  • #20944 Upgrade to ASM 6.2 ("depends on")
  • #21800 Upgrade to ASM 7.0 ("depends on")
  • #20414 MethodHandles.Lookup.defineClass for CGLIB class definition purposes ("depends on")
  • #21515 Classpath scanning does not work in tests using the module path
  • #21633 Classpath scanning on inner classes fails against JDK 11 bytecode level
  • #21630 Classification of ClassCastExceptions doesn't work in JDK 11 (OpenJDK)
  • DATACMNS-1373 Align class loading in ClassGeneratingEntityInstantiator with ClassGeneratingPropertyAccessorFactory

Referenced from: commits 93bb78e, 5094941

2 votes, 13 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 3, 2018

Juergen Hoeller commented

Unfortunately, the Groovy 2.5.1 compiler still isn't JDK 11 compatible... apparently due to its use of ASM 6.2 without the ASM 7 experimental option (see #21633 for a similar case on our end). As a consequence, our build still doesn't run on JDK 11 (build 25).

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 14, 2018

Juergen Hoeller commented

As of 5.1.1, we run the build against Groovy 2.5.3 which executes fine on JDK 11. Including an upgrade of spring-test to use Hibernate ORM 5.3.6 instead of 5.2.17, this makes our entire build pass on JDK 11 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.