Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segregate BasicTraceInterceptor from CustomizableTraceInterceptor [SPR-16451] #20996

Open
spring-projects-issues opened this issue Feb 1, 2018 · 2 comments
Labels
in: core status: waiting-for-triage

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Feb 1, 2018

Sergii Karpenko opened SPR-16451 and commented

Segregate basic trace logic from logic responsible for log message construction.
Move out invokeUnderTrace to BasicTraceInterceptor
and parametrise it with entranceConsumer, exitConsumer, exceptionConsumer.

Except of violating single responsibility principle current implementation doesn't allow me to distinguish entrance message from exit massages.

This should fix both points and also will allow to avoid of expensive replacePlaceholders calls if necessary.


No further details from SPR-16451

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 1, 2018

Sergii Karpenko commented

BTW, BasicTraceInterceptor also can be used as superclass for SimpleTraceInterceptor to avoid code duplication

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Feb 2, 2018

Sergii Karpenko commented

If you don't mind I'd like to introduce this safe refactoring.

@spring-projects-issues spring-projects-issues added status: waiting-for-triage in: core type: task and removed type: task labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: waiting-for-triage
Projects
None yet
Development

No branches or pull requests

1 participant