Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of StringUtils#trimWhitespace method [SPR-16766] #21307

Closed
spring-projects-issues opened this issue Apr 24, 2018 · 1 comment
Closed
Assignees
Labels
in: core type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Apr 24, 2018

Oleksandr Hasheniuk opened SPR-16766 and commented

Cutting whitespaces once prevents calling System#arrayCopy on every deleted char. With using String#substring method it would be called just once.


Affects: 5.0.5

Referenced from: pull request #1805, and commits 6545cab, 5a1d7f9

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 1, 2018

Juergen Hoeller commented

Good point! Merged to master now; I'll make sure to backport this to 5.0.6 as well.

@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.6 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants