New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve toString in path extension and query parameter predicates [SPR-16829] #21369

Closed
spring-issuemaster opened this Issue May 16, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented May 16, 2018

Arjen Poutsma opened SPR-16829 and commented

Unlike the other RequestPredicate implementations, the RequestPredicates.queryParam and RequestPredicates.pathExtension predicates are implemented as inline lambda's. Lambda's do not have a usable toString, making them useless for logging purposes.

We should move the lambda's for these extensions to inner classes, so that they can have a proper toString}.


No further details from SPR-16829

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented May 17, 2018

Arjen Poutsma commented

I also added a toString for filtered router functions.

See 7424ca5 and b03905e for commits on 5.1.x.

See d24546a and 3c88029 for commits on 5.0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment