New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerHttpRequest.Builder should allow setting SslInfo [SPR-16830] #21370

Closed
spring-issuemaster opened this Issue May 16, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented May 16, 2018

nebhale opened SPR-16830 and commented

In Spring Framework 5.0.2 ServerHttpRequest#getSslInfo() was added in order to expose a connection's TLS information to handlers. Currently, the ServerHttpRequest.Builder does not have a method allowing mutators of the request to mutate the TLS information. This prevents a WebFilter from intercepting the request and modifying this information.

The ServerHttpRequest.Builder should gain the functionality to mutate the TLS information for a request, preferably in an additive way, e.g. adding to rather than replacing the peer certificates.


Affects: 5.0.6

Referenced from: commits fbd12e9, e3e975d

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented May 16, 2018

Rossen Stoyanchev commented

Rob Winch, Spencer Gibb, please weigh in if you'd like this in 5.0.x as well? It's straight-forward enough that we could make an exception at this stage of 5.0.x.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented May 16, 2018

Spencer Gibb commented

I think it would be useful for those waiting on spring cloud gateway that could use the functionality without waiting for 5.1.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented May 16, 2018

Rossen Stoyanchev commented

Okay, I've added 5.0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment