New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring overrides user requested STOMP version [SPR-16844] #21384

Closed
spring-issuemaster opened this Issue May 18, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented May 18, 2018

Jon Kranes opened SPR-16844 and commented

There is currently no way for a client application to set the accepted STOMP version value.  In the org.springframework.messaging.simp.stomp.DefaultStompSession.afterConnected() method, the code calls 

accessor.setAcceptVersion("1.1,1.2");

This overrides any version that the application may have requested in the StompHeaders.   The preferred behavior would be to check the StompHeaders for an "accept-version" header and if found use that value instead of the hard-coded "1.1,1.2" value.

The specific use case I have for this feature is that there is currently a bug in the Apache Artemis message broker that affects STOMP 1.2 but not STOMP 1.1.  Therefore to avoid this bug I would like to specify STOMP 1.1 but using a Spring based client I am unable to do so.


Affects: 5.0.5

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented May 18, 2018

Rossen Stoyanchev commented

This would have to be a version actually supported by the client, i.e. one of 1.1 or 1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment