New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractRequestLoggingFilter.isIncludeHeaders() is accidentally public [SPR-16881] #21420

Closed
spring-issuemaster opened this Issue May 29, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented May 29, 2018

Juergen Hoeller opened SPR-16881 and commented

The includeHeaders property introduced in #18818 accidentally has a public getter whereas all other such properties on AbstractRequestLoggingFilter are protected.


Affects: 4.3.17, 5.0.6

Issue Links:

  • #18818 Add option to log headers to AbstractRequestLoggingFilter

Referenced from: pull request #1838, and commits a2d7cc7, c754232

Backported to: 4.3.18

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented May 29, 2018

Juergen Hoeller commented

Fixed as part of a slightly wider revision on master; I'll backport this to 5.0.x and 4.3.x ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment