Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveBeansView should support double quotes in application context id [SPR-16899] #21438

Closed
spring-projects-issues opened this issue Jun 4, 2018 · 1 comment
Closed

LiveBeansView should support double quotes in application context id [SPR-16899] #21438

spring-projects-issues opened this issue Jun 4, 2018 · 1 comment
Labels
in: core status: declined type: enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jun 4, 2018 •
edited

Konstantin Aleev opened SPR-16899 and commented

result.append("{\n"context": "").append(context.getId()).append("",\n"); in org.springframework.context.support.LiveBeansView.generateJson(Set<ConfigurableApplicationContext>) creates invalid JSON if context id already has double quotes.

 

The problem could be reproduced by assigning some string with double quotes to 'spring.application.name' in Spring Boot application.

Affects: 5.0.6

Issue Links:

  • #18773 LiveBeansView doesn't contain singletons registered programmatically
  • #21327 LiveBeansView is not really fit for purpose any more
@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Jan 11, 2019
Closed
Closed
@sbrannen
Copy link
Member

@sbrannen sbrannen commented Feb 9, 2021

Closing since LiveBeansView is now deprecated (see #25820).

@sbrannen sbrannen closed this as completed Feb 9, 2021
@sbrannen sbrannen removed this from the General Backlog milestone Feb 9, 2021
@sbrannen sbrannen added the status: declined label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core status: declined type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbrannen @spring-projects-issues