Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractJackson2HttpMessageConverter incorrectly logs at WARN level after upgrading to Jackson 2.9 [SPR-16947] #21486

Closed
spring-issuemaster opened this issue Jun 17, 2018 · 3 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Jun 17, 2018

Mark Chesney opened SPR-16947 and commented

The verbiage of exception messages changed from "Can not find" to "Cannot find" in Jackson 2.9 with PR #1682

e.g.

WARN o.s.h.c.j.MappingJackson2HttpMessageConverter : Failed to evaluate Jackson deserialization for type [[collection type; class com.google.common.collect.ImmutableList...


Affects: 4.3.18, 5.0.7

Issue Links:

  • #18735 MappingJackson2HttpMessageConverter should not always log a warning

Referenced from: pull request #1859

Backported to: 4.3.19

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jun 17, 2018

Juergen Hoeller commented

Good catch! I'll backport this to 5.0.8 and 4.3.19 ASAP.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jun 17, 2018

Juergen Hoeller commented

I've also adapted our analogous detection logic in org.springframework.messaging.converter.MappingJackson2MessageConverter accordingly (which currently is a duplicate of AbstractJackson2HttpMessageConverter.logWarningIfNecessary since there is no proper place to reuse it from).

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jun 17, 2018

Juergen Hoeller commented

It turns out that we can simplify this to just a "Cannot find" check on Spring Framework 5.1 since we formally require Jackson 2.9+ now. In the backports, we'll have to check for both variants (even if we technically require Jackson 2.9+ in a few places for other reasons already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.