Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cache-control: immutable [SPR-17013] #21551

Closed
spring-projects-issues opened this issue Jul 6, 2018 · 2 comments
Closed

Add support for cache-control: immutable [SPR-17013] #21551

spring-projects-issues opened this issue Jul 6, 2018 · 2 comments
Labels
status: declined

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jul 6, 2018

Phil Webb opened SPR-17013 and commented

Originally raised in the Spring Boot issue tracker (#13715):

We are facing an issue where even we set all appropriate options delineated at: https://docs.spring.io/spring-boot/docs/current/reference/html/common-application-properties.html the caching still does not work completely on Firefox. The goal is to have static files cached on local browser for users, with no re-fetching if the cache has not expired. Whereas what we see is that the cache gets invalidated every other time (caches only half of the time, and the response code flip-flops between 200 and 304). Turns out that firefox relies on cache-control: immutable to make sure the cache does not get invalidated.

Looking at https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/CacheControl.html , there is no option to set that immutable flag, is it possible to add the option?


No further details from SPR-17013

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 6, 2018

Brian Clozel commented

While this feature is supported by Firefox, Safari and Edge, it is still considered as experimental. Also, the Chromium team decided against it so it is not supported with that browser.

For those reasons, I'm leaving this issue opened, but unscheduled for now.

@spring-projects-issues spring-projects-issues added type: enhancement in: web labels Jan 11, 2019
@bclozel bclozel added status: declined and removed in: web type: enhancement labels Apr 1, 2020
@bclozel
Copy link
Member

@bclozel bclozel commented Apr 1, 2020

Browser support is still very poor and won't change apparently. I'm closing this issue now.
We can revisit this decision if the situation changes.

@bclozel bclozel closed this as completed Apr 1, 2020
@jhoeller jhoeller removed this from the General Backlog milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined
Projects
None yet
Development

No branches or pull requests

3 participants