Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide control over logging of potentially sensitive request details [SPR-17029] #21567

Closed
spring-projects-issues opened this issue Jul 10, 2018 · 0 comments
Assignees
Labels
in: web type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jul 10, 2018

Rossen Stoyanchev opened SPR-17029 and commented

Following the changes for #21437, potentially sensitive data including request params / form data may be logged at DEBUG level, and headers at TRACE level.

The initial approach implemented was to log such data at DEBUG and TRACE level by default along with a loud warning on startup and a flag to disable such logging. However the warning is only useful in the beginning and creates a lot of noise on every startup Ultimately it cannot effectively help avoid potential issues when running in production.

The current thinking is to log at DEBUG and TRACE level still, by default but use slightly different output that shows the data is there but masked, along with a flag to enable showing it, and a toned down log message on startup.

For example on startup:

enableLoggingRequestDetails='false': request parameters and headers will be masked to prevent unsafe logging of potentially sensitive data

Then at runtime:

GET "/myPath.do", parameters={masked}, headers={masked}

Affects: 5.0.7

This issue is a sub-task of #21485

Referenced from: commits 1b1bc7f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: task
Projects
None yet
Development

No branches or pull requests

2 participants