Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-webflux ModelAttributeMethodArgumentResolver validateIfApplicable [SPR-17073] #21611

Closed
spring-projects-issues opened this issue Jul 20, 2018 · 1 comment
Assignees
Labels
in: web type: bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jul 20, 2018

Tian Wang opened SPR-17073 and commented

spring-web the same function code is

Object[] validationHints = determineValidationHints(ann);

spring-webflux is 

Object hintArray = (hints instanceof Object[] ? (Object[]) hints : new Object[] {hints});

should be 

Object[] hintArray = (hints instanceof Object[] ? (Object[]) hints : new Object[] {hints});

 

 


Affects: 5.0.5

Issue Links:

  • #21381 Validation failure not exposed next to binding failure for immutable form class

Referenced from: commits 3c65c17, 192113d

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 21, 2018

Juergen Hoeller commented

Good catch! I'll generally align that code with 5.1's revision in ModelAttributeMethodProcessor, also not passing in empty hints as null but rather as empty array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: bug
Projects
None yet
Development

No branches or pull requests

2 participants