Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize class detection by sharing the ClassLoader [SPR-17083] #21620

Closed
spring-projects-issues opened this issue Jul 25, 2018 · 3 comments
Closed
Assignees
Labels
type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jul 25, 2018

Sébastien Deleuze opened SPR-17083 and commented


No further details from SPR-17083

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 25, 2018

Christoph Dreis commented

Sweet. You don't happen to have any numbers about the improvement, Sébastien Deleuze?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 25, 2018

Sébastien Deleuze commented

Nope, the idea came to me while polishing #20331 yesterday night, and I have no figures but that's part of our global 5.1 optimization theme, so it will be interesting to compare 5.0 versus 5.1 global startup time and heap consumption.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 25, 2018

Juergen Hoeller commented

This one seems largely a syntactic optimization for larger init blocks since Class.getClassLoader() is a very efficient call. Nice in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task
Projects
None yet
Development

No branches or pull requests

2 participants