Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataBufferUtils#takeUntilByteCount checks one extra buffer but does not release it [SPR-17118] #21655

Closed
spring-issuemaster opened this issue Aug 2, 2018 · 0 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 2, 2018

Rossen Stoyanchev opened SPR-17118 and commented

The current implementation relies on Flux#takeWhile to be invoked with one extra buffer beyond the buffer for which the max byte count was reached. However that extra buffer is not released. Arguably it should not even have to wait for for an extra buffer, when it already knows the max byte count was reached.


Affects: 5.0.8

Issue Links:

  • #21563 DataBufferUtils#join could leak buffers in case of error from the source
  • #21527 Add ExchangeFilterFunction that enforces limit on the response size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.