Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent nullability for StringUtils array/collection input parameters [SPR-17123] #21660

Closed
spring-issuemaster opened this issue Aug 6, 2018 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 6, 2018

rinx opened SPR-17123 and commented

Spring Framework 5.1 provides a function named StringUtils.collectionToCommaDelimitedString which is defined here:

https://github.com/spring-projects/spring-framework/blob/master/spring-core/src/main/java/org/springframework/util/StringUtils.java#L1289

has argument type "Collection<?> coll".

However, it calls collectionToDelimitedString which accepts "Nullable" collection. I think collectionToCommaDelimitedString should be able to handle "Nullable" collection.


Affects: 5.1 RC1

Referenced from: pull request #1917, and commits 69c6a40

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 6, 2018

Juergen Hoeller commented

Well spotted! In fact, there are other nullability inconsistencies in StringUtils as well. I'll revisit them combined in a larger revision for 5.1 RC2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.