Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DataSize type [SPR-17154] #21691

Closed
spring-issuemaster opened this issue Aug 9, 2018 · 2 comments
Closed

Introduce DataSize type [SPR-17154] #21691

spring-issuemaster opened this issue Aug 9, 2018 · 2 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 9, 2018

Stéphane Nicoll opened SPR-17154 and commented

There is no data type to represent a size at the moment and it would be interesting to have such type, in particular for binding purpose


Affects: 5.1 RC1

Referenced from: commits f931a3f, 8a1588a

1 votes, 2 watchers

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 10, 2018

Stéphane Nicoll commented

We should probably support negative sizes as well. A typical use case is to specify a negative number to disable a feature.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 10, 2018

Stéphane Nicoll commented

I've improved DataSize to support negative values in this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.