Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy capability to Netty4ClientHttpRequestFactory [SPR-17175] #21711

Open
spring-issuemaster opened this issue Aug 13, 2018 · 2 comments
Open

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 13, 2018

Sergey Galkin opened SPR-17175 and commented

We are heavily using RestTemplate and recently received requirement to use SOCKS5 proxy with authentication. So our requirements list for http client is:

  • configurable timeout
  • socks5 proxy with auth
  • client ssl certificates

After researching available http clients I see following possible solutions:

  • replace RestTemplate with reactive WebClient
  • create ReactiveWebClientRequestFactory and use it with RestTemplate
  • add proxy capability to Netty4ClientHttpRequestFactory and use it with existing RestTemplate

Last option requires minimal changes. The only downside is that Netty4ClientHttpRequestFactory is deprecated.
Is it worth creating PR for this improvement?


Affects: 5.0.8

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 13, 2018

Rossen Stoyanchev commented

What exactly is the change? Obviously the class is deprecated and we don't want to add features that may require further evolution.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 14, 2018

Sergey Galkin commented

Here is possible implementation #1928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.