Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose InterfaceTypeFilter and AllTypeFilter classes as public [SPR-17186] #21721

Closed
spring-projects-issues opened this issue Aug 15, 2018 · 1 comment
Assignees
Labels
in: core status: duplicate type: enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Aug 15, 2018

lgoldstein opened SPR-17186 and commented

When scanning for components one needs to provide TypeFilter-s for including/excluding candidates. There are currently 2 useful implementations that are defined as private classes with public constructors - namely org.springframework.data.repository.config.RepositoryComponentProvider.InterfaceTypeFilter and org.springframework.data.repository.config.RepositoryComponentProvider.AllTypeFilter. After examining their code there does not seem to be any special reason for "hiding" them - especially since they are so useful. I propose making them public and perhaps moving them to their own class file instead of being inner classes. This should pose no backward compatibility issues since existing code does not "see" these classes anyway.


Affects: 5.0.8

Issue Links:

  • DATACMNS-1372 Expose InterfaceTypeFilter and AllTypeFilter classes as public ("duplicates")
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 15, 2018

Juergen Hoeller commented

I've moved your previous report to the Spring Data project since these are not core framework classes. Any specific follow-up at the core framework level can be dealt with here but let's leave the initial round of review over there in Spring Data.

@spring-projects-issues spring-projects-issues added type: enhancement in: core status: duplicate labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: duplicate type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants