SmartLifecycle should provide default methods [SPR-17188]

[spring-issuemaster]

Yanming Zhou opened SPR-17188 and commented

Normally the motivation of Using SmartLifecycle instead of Lifecycle is make it auto startup, so we should return true by default, and most SmartLifecycle doesn't care about concurrent shutdown, we should provide a default stop method to avoid misuse shutdown order.

default boolean isAutoStartup() {
     return true;
}
default void stop(Runnable callback) {
     this.stop();
     callback.run();
}

---

Affects: 5.0.8

Issue Links:

• #21699 Use default methods on Smart/GenericApplicationListener

Referenced from: pull request #1929

[spring-issuemaster]

Juergen Hoeller commented

Good idea! I'm taking this even one support further, also covering the Phased implementation with a default value and documenting the default implementations, along the lines of our recent SmartApplicationListener revision (#21699).

[spring-issuemaster]

Juergen Hoeller commented

I'm using a default phase of Integer.MAX_VALUE in line with the existing SmartLifecycle implementations, as a default phase for SmartLifecycle beans (different from the assumed phase 0 for regular Lifecycle beans which therefore come first by default).