Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate empty adapter classes which replaced by interface with default methods [SPR-17190] #21725

Open
spring-issuemaster opened this issue Aug 16, 2018 · 1 comment
Labels
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 16, 2018

Yanming Zhou opened SPR-17190 and commented

Those legacy adapter class should be marked as @Deprecated and remove in future, such as TransactionSynchronizationAdapter and HandlerInterceptorAdapter.


No further details from SPR-17190

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 16, 2018

Juergen Hoeller commented

Indeed, those adapter classes are effectively on their way out...

We just didn't feel it was necessary to deprecate them and force people to avoid them or put @SuppressWarnings on their subclasses quite yet. Also, we have a few subclasses ourselves there that we'll have to refactor to straight implementations of the corresponding interface. For the time being, it doesn't hurt to retain assignability to the adapter classes there, just in case somebody makes a corresponding assumption in custom inspection code.

We'll probably do that round of cleanup for 5.2 and remove them altogether in 6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.