Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleAliasRegistry.hasAlias does not properly resolve multiple chained aliases [SPR-17191] #21726

Closed
spring-projects-issues opened this issue Aug 17, 2018 · 1 comment
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 17, 2018

hachi029 opened SPR-17191 and commented

here are test cases:

SimpleAliasRegistry sar = new SimpleAliasRegistry();
sar.registerAlias("name", "alias_a");
sar.registerAlias("name", "alias_b");
sar.registerAlias("real_name", "name");

assertTrue((sar).hasAlias("real_name", "alias_b")); //case 1
sar.registerAlias("name", "alias_d");
assertFalse((sar).hasAlias("real_name", "alias_b")); //case 2


Affects: 4.3.18

Backported to: 4.3.19

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Aug 17, 2018

Juergen Hoeller commented

Good catch! The hasAlias loop continues throughout all chained aliases now, properly resolving such a scenario with multiple chained aliases as well.

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.9 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants