Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleAliasRegistry.hasAlias does not properly resolve multiple chained aliases [SPR-17191] #21726

Closed
spring-issuemaster opened this issue Aug 17, 2018 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 17, 2018

hachi029 opened SPR-17191 and commented

here are test cases:

SimpleAliasRegistry sar = new SimpleAliasRegistry();
sar.registerAlias("name", "alias_a");
sar.registerAlias("name", "alias_b");
sar.registerAlias("real_name", "name");

assertTrue((sar).hasAlias("real_name", "alias_b")); //case 1
sar.registerAlias("name", "alias_d");
assertFalse((sar).hasAlias("real_name", "alias_b")); //case 2


Affects: 4.3.18

Backported to: 4.3.19

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 17, 2018

Juergen Hoeller commented

Good catch! The hasAlias loop continues throughout all chained aliases now, properly resolving such a scenario with multiple chained aliases as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.