Skip to content

/ spring-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HeaderAssertions.lastModified/expires takes an int value but it should be long [SPR-17194] #21729

Closed
spring-issuemaster opened this issue Aug 17, 2018 · 2 comments
Closed

HeaderAssertions.lastModified/expires takes an int value but it should be long [SPR-17194] #21729

spring-issuemaster opened this issue Aug 17, 2018 · 2 comments
Assignees
@rstoyanchev
Labels
in: test in: web type: bug
Milestone
5.0.9

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Aug 17, 2018 •
edited

Toshiaki Maki opened SPR-17194 and commented

https://github.com/spring-projects/spring-framework/blob/v5.0.8.RELEASE/spring-test/src/main/java/org/springframework/test/web/reactive/server/HeaderAssertions.java#L152-L164

 lastModified/expires should take a long value as int can express up to 1970-01-25T20:31:23.647Z ...

Affects: 5.0.8, 5.1 RC2

Issue Links:

  • #21730 Some WebTestClient HeaderAssertions' methods unusable ("is duplicated by")

Referenced from: pull request #1931
@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 17, 2018

Toshiaki Maki commented

Sent a PR

#1931

 
@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Aug 20, 2018 •
edited

Juergen Hoeller commented

Since the comparisons don't seem to work at all due to a long/int mismatch in the headers map (according to #21730), I've changed this one to a bug ticket.
@spring-issuemaster spring-issuemaster added this to the 5.0.9 milestone Jan 11, 2019
@spring-issuemaster spring-issuemaster mentioned this issue Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: test in: web type: bug
Projects
None yet
Milestone
5.0.9
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@rstoyanchev @spring-issuemaster
You can’t perform that action at this time.