Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some WebTestClient HeaderAssertions' methods unusable [SPR-17195] #21730

Closed
spring-projects-issues opened this issue Aug 19, 2018 · 0 comments
Closed
Labels
in: test status: duplicate

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Aug 19, 2018

Konrad Czajka opened SPR-17195 and commented

HeaderAssertions::expires(int) and HeaderAssertions::lastModified(int) accept integers whereas HttpHeaders stores (and return) both headers as longs.
As Object::equals is used for comparison the methods always fail.

They should either cast incoming values to long before comparing them or become deprecated in favor of "long" overloads.


Issue Links:

  • #21729 HeaderAssertions.lastModified/expires takes an int value but it should be long ("duplicates")

Referenced from: pull request #1933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test status: duplicate
Projects
None yet
Development

No branches or pull requests

1 participant