Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide code samples in Kotlin in addition to Java [SPR-17245] #21778

Closed
spring-issuemaster opened this issue Sep 5, 2018 · 3 comments
Closed

Provide code samples in Kotlin in addition to Java [SPR-17245] #21778

spring-issuemaster opened this issue Sep 5, 2018 · 3 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Sep 5, 2018

Sébastien Deleuze opened SPR-17245 and commented

Even if we have a dedicated Kotlin section in our reference documentation, all the code samples are in Java, requiring an effort for Kotlin users to translate it. I would like to make our documentation more natively Kotlin friendly by translating our code example to Kotlin.

This could be done via a Kotlin tab (in addition to the Java one) on each code sample block, and by generating 2 versions of the documentation: one in Java, one in Kotlin.


1 votes, 3 watchers

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 8, 2018

Sébastien Deleuze commented

Gradle team shared what they use on their documentation to have nice looking Groovy + Kotlin code snippets + cookie based remembering of the chosen language. I think it could be a good fit for us, it would be also nice to be able to link a specific language like we do on start.spring.io.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 15, 2018

Sébastien Deleuze commented

There is now also a dedicated blog post.

@spring-issuemaster spring-issuemaster added this to the 5.2 RC1 milestone Jan 11, 2019
@jhoeller jhoeller modified the milestones: 5.2 M1, 5.2 RC1 Mar 23, 2019
@sdeleuze sdeleuze modified the milestones: 5.2 M3, 5.2 RC1 Jun 7, 2019
@sdeleuze sdeleuze modified the milestones: 5.2 RC1, 5.2 GA Jul 8, 2019
@sdeleuze sdeleuze modified the milestones: 5.2 GA, 5.2 RC2 Aug 12, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 12, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 12, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 12, 2019
This commit introduces Kotlin code snippets, for now
in the core reference documentation. Other sections
will follow, as well as improvements like global
language switch.

See spring-projectsgh-21778
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 12, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 13, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 13, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 14, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 14, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 14, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 14, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 22, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 28, 2019
kohlmu-pivotal added a commit to kohlmu-pivotal/spring-framework that referenced this issue Aug 30, 2019
kohlmu-pivotal added a commit to kohlmu-pivotal/spring-framework that referenced this issue Aug 30, 2019
Adding code callouts for both Java and Kotlin

See - spring-projectsgh-21778
kohlmu-pivotal added a commit to kohlmu-pivotal/spring-framework that referenced this issue Aug 30, 2019
kohlmu-pivotal added a commit to kohlmu-pivotal/spring-framework that referenced this issue Aug 30, 2019
Adding code callouts for both Java and Kotlin

See - spring-projectsgh-21778
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 30, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 30, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 30, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 30, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 31, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 31, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 31, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 31, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 31, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 31, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 31, 2019
@sdeleuze sdeleuze closed this in 3dfd0a2 Aug 31, 2019
@sdeleuze
Copy link
Contributor

@sdeleuze sdeleuze commented Aug 31, 2019

All major parts of the reference documentation now have Kotlin code samples: Core, Testing, WebFlux and WebMvc. Other places will be completed later.

sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.