Remove/overwrite header in MockHttpServletRequest [SPR-17288]

[spring-projects-issues]

Christopher Smith opened SPR-17288 and commented

MockHttpServletRequest supports adding arbitrary headers, but subsequent calls to addHeader always append the new values. While the internal doAddHeaderValue takes a boolean to specify replacement, it's not visible externally. When using the class for testing, it is often useful to construct it with the usual headers in a setup method, but there's no way to then overwrite a header per-test.

It would be useful to be able to remove an existing header from the request (either to leave it missing or to then replace it with a new value).

---

Affects: 4.3.19

Issue Links:

• #21828 Support for removeHeader in MockHttpServletRequest

[spring-projects-issues]

Rossen Stoyanchev commented

#21828 added removeHeader recently that should give you the ability to remove and before adding.

[spring-projects-issues]

Christopher Smith commented

That looks like what I was asking for; didn't find it in search for some reason. It looks like a fairly simple change; could we get a backport to 4.3?

[spring-projects-issues]

Rossen Stoyanchev commented

Please add a comment under #21828.

[spring-projects-issues]

Rossen Stoyanchev commented

Resolving in favor of  #21828.