Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary sort in AbstractApplicationEventMulticaster [SPR-17307] #21840

Closed
spring-projects-issues opened this issue Sep 27, 2018 · 1 comment
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Sep 27, 2018

Nick Hristov opened SPR-17307 and commented

org.springframework.context.event.AbstractApplicationEventMulticaster.ListenerRetriever#getApplicationListeners method performs an unnecessary sort:

It creates a list which is a combination of this.applicationListeners and this.applicationListenerBeans and sorts that list. However, the sorting is unnecessary if either one of the two collections is empty. Furthermore, due to the fact that the sorting utilizes the reflection lookups, this sort can become an expensive unnecessary overhead in some use cases.

In my case, I load large amounts of data (> 1K of objects) via Spring Data Mongo which fires off events for every object loaded in the system.

So the sort operation ends up taking about 38% of the overall cost of the processing, more than any other component in my use case.
 


Affects: 5.0.5

Attachments:

Issue Links:

Backported to: 5.0.10

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

AbstractApplicationEventMulticaster maintains a pre-sorted list for singleton listeners now, sourced from applicationListeners as well as applicationListenerBeans entries which happen to point to a singleton bean (which we can also reliably cache and sort upfront). This effectively avoids the sort operation for repeated listener invocations as long as all listeners are singleton beans... which is hopefully good enough for the common scenarios out there. As a side benefit, it also avoids repeated getBean retrieval for singleton listener beans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants