Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimeFormat Javadoc is not correct [SPR-17366] #21899

Closed
spring-projects-issues opened this issue Oct 11, 2018 · 1 comment
Closed

DateTimeFormat Javadoc is not correct [SPR-17366] #21899

spring-projects-issues opened this issue Oct 11, 2018 · 1 comment
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: task A general task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 11, 2018

volkovandr opened SPR-17366 and commented

The javadoc here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/format/annotation/DateTimeFormat.ISO.html#DATE_TIME

states that the ISO DATE_TIME format uses the pattern 

yyyy-MM-dd'T'HH:mm:ss.SSSZ

but in fact the pattern is 

yyyy-MM-dd'T'HH:mm:ss.SSSXXX

The change was made by this commit:

bb94ba6#diff-4e8b86c8c802560c74bf5647b9c91bb6

The javadoc needs to be changed to reflect the reality. The same also applies for the TIME format.


Affects: 5.0.3, 5.0.4, 5.0.5, 5.0.6, 5.0.7, 5.0.8, 5.0.9, 5.1 GA

Issue Links:

Referenced from: pull request #1989, and commits b043381, 61403e3

Backported to: 5.0.10

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 11, 2018

Juergen Hoeller commented

PR 1989 has been applied to master already. I'll use this ticket for tracking the backport to 5.0.10.

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants