Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodValidationPostProcessor still validates FactoryBean methods on CGLIB proxies [SPR-17386] #21919

Closed
spring-issuemaster opened this issue Oct 15, 2018 · 0 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 15, 2018

Juergen Hoeller opened SPR-17386 and commented

As mentioned in #21907 comments, the initial fix only covers the interface-based proxy case but unfortunately still runs into a stack overflow against CGLIB proxies. This incurs a significantly more expensive check at runtime, so let's see what we can do about it.


Affects: 4.3.20, 5.0.10, 5.1.1

Issue Links:

  • #21907 MethodValidationPostProcessor validates FactoryBean methods for which validation is not applicable
  • #21964 MethodValidationPostProcessor does not support JDK proxy from FactoryBean

Backported to: 5.0.11, 4.3.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.