Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS detection for reactive stack on tomcat/netty is broken [SPR-17396] #21929

Closed
spring-projects-issues opened this issue Oct 17, 2018 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 17, 2018

Johannes Edmeier opened SPR-17396 and commented

The CorsUtils queries the presence of the Origin and Access-Control-Request-Method with a simple non null check. But when using the reactive stack the TomcatHeadersAdapter#get() and the NettyHeadersAdapter#get() returns an empty list (instead of null) when the requested header is not present.
The effect of this is, that OPTIONS requests aren't handled with the (correct) annotated handler method but are incorrectly handled as preflight requests (which they aren't)


Affects: 5.1.1

Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 18, 2018

Brian Clozel commented

Thanks Johannes Edmeier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants