Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InvocableHandlerMethod.getMethodArgumentValues from private to protected. [SPR-17404] #21937

Closed
spring-projects-issues opened this issue Oct 18, 2018 · 2 comments
Assignees
Labels
in: web type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 18, 2018

sofior opened SPR-17404 and commented

I want to overwrite invokeForRequest to log the request param response and processing time to the db but the method of getMethodArgumentValues is private so I want change it to protected


Attachments:

Referenced from: pull request #1995 (comment), and commits 5b5f719

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 18, 2018

sofior commented

I use reflect to call the method now see the LoggingRegistration.java

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 18, 2018

Juergen Hoeller commented

I've rolled this into master in an extended fashion, declaring getMethodArgumentValues as protected in both the web and the messaging variant of InvocableHandlerMethod, with revised javadoc that explains the invocation order.

@spring-projects-issues spring-projects-issues added type: enhancement in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants