Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InvocableHandlerMethod.getMethodArgumentValues from private to protected. [SPR-17404] #21937

Closed
spring-issuemaster opened this issue Oct 18, 2018 · 2 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 18, 2018

sofior opened SPR-17404 and commented

I want to overwrite invokeForRequest to log the request param response and processing time to the db but the method of getMethodArgumentValues is private so I want change it to protected


Attachments:

Referenced from: pull request #1995 (comment), and commits 5b5f719

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 18, 2018

sofior commented

I use reflect to call the method now see the LoggingRegistration.java

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 18, 2018

Juergen Hoeller commented

I've rolled this into master in an extended fashion, declaring getMethodArgumentValues as protected in both the web and the messaging variant of InvocableHandlerMethod, with revised javadoc that explains the invocation order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.