Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review DataBuffer handling in Servlet and Undertow server adapters [SPR-17410] #21943

Closed
spring-issuemaster opened this issue Oct 18, 2018 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 18, 2018

Rossen Stoyanchev opened SPR-17410 and commented

For Reactor Netty, we can drop onDiscard from server request, since Reactor Netty is expected to handle this. Likewise for the Undertow which does not use Reactor Core upstream for the server request body.

Review the use of data buffers in the Reactive Streams adapter layer to ensure discarding of in-flight data buffers on error and cancellation.


Affects: 5.0.10, 5.1.1

This issue is a sub-task of #21941

Referenced from: commits 862dd23, 0e8ed59, 36510cf, 8de86b7

Backported to: 5.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.