Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review DataBuffer handling in Servlet and Undertow server adapters [SPR-17410] #21943

Closed
spring-projects-issues opened this issue Oct 18, 2018 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: task A general task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 18, 2018

Rossen Stoyanchev opened SPR-17410 and commented

For Reactor Netty, we can drop onDiscard from server request, since Reactor Netty is expected to handle this. Likewise for the Undertow which does not use Reactor Core upstream for the server request body.

Review the use of data buffers in the Reactive Streams adapter layer to ensure discarding of in-flight data buffers on error and cancellation.


Affects: 5.0.10, 5.1.1

This issue is a sub-task of #21941

Referenced from: commits 862dd23, 0e8ed59, 36510cf, 8de86b7

Backported to: 5.0.11

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 23, 2018

Rossen Stoyanchev commented

Re-opening for the backport.

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants