Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review DataBufferUtils [SPR-17411] #21944

Closed
spring-issuemaster opened this issue Oct 19, 2018 · 2 comments
Closed

Review DataBufferUtils [SPR-17411] #21944

spring-issuemaster opened this issue Oct 19, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 19, 2018

Arjen Poutsma opened SPR-17411 and commented

DataBufferUtils should handle both error and cancellation signals. Currently join does error only, while readByteChannel and readAsynchronousFileChannel do onDiscard which does both. Other methods like takeUntil to be reviewed.


This issue is a sub-task of #21941

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 19, 2018

Arjen Poutsma commented

Fixed in 149d416

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 24, 2018

Arjen Poutsma commented

One more: 488a1d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.