Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceUrlEncodingFilter does not work with HttpServletRequestWrapper [SPR-17421] #21954

Closed
spring-issuemaster opened this issue Oct 22, 2018 · 3 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Oct 22, 2018

Rob Winch opened SPR-17421 and commented

This is effectively reopening of #17152 I was able to reproduce this without Spring Security via a Filter that wraps the HttpServletRequest. See https://github.com/rwinch/spring-framework-issues/tree/SPR-12550-Security/SPR-12550 There are instructions in the README for reproducing.


Affects: 4.3.19

Issue Links:

  • #21521 ForwardedHeaderFilter does not respect Servlet forwarding
  • #17152 Rewriting URLs with version-resolver using JSP and c:url doesn't work when Spring dispatcher servlet is not mapped to root ("supersedes")

Backported to: 5.0.11, 4.3.21

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 26, 2018

vandykej17 commented

HI, I see this has been resolved through #21521. One followup question: #21521 lists Fix Version/s of 5.1.2, but this ticket lists out three Fix Version/s (4.3.215.0.115.1.2). Our application uses Spring 4 right now, so getting the fix in 4.3.21 would be optimal for us.  Would that be possible?

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 26, 2018

Brian Clozel commented

Hi vandykej17,

This issue has been resolved here, not through #21521. The fix has been backported to 4.3.x and 5.0.x branches, so this will be available in 4.3.21, 5.0.11 and 5.1.2.

On the other hand, #21521 has been fixed on master only, but it is a totally different fix. Are you requesting a backport for #21521 independently of this issue?

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Oct 26, 2018

vandykej17 commented

Oh, sorry I guess I misunderstood what the related to field meant. I don't need #21521 back ported. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.