Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract base classes for Encoder/Decoder [SPR-17449] #21981

Closed
spring-projects-issues opened this issue Oct 31, 2018 · 2 comments
Closed

Add abstract base classes for Encoder/Decoder [SPR-17449] #21981

spring-projects-issues opened this issue Oct 31, 2018 · 2 comments
Assignees
Labels
in: core type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 31, 2018

Arjen Poutsma opened SPR-17449 and commented

Recent reviews on Encoder and Decoder classes has shown that it is still too easy to make mistakes when creating them. We should add abstract base classes or helper classes that check common codec testing scenarios:

  • Encode a Flux of objects into a Flux of data buffers. Release the returned data buffers, but make sure that there are not other buffers which are still allocated.
  • Decode a Flux of data buffers into a Flux of objects. Make sure that all data buffers have been released.
  • As above, but with an error in the input stream.
  • As above, but cancel the stream after one received element.

No further details from SPR-17449

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 13, 2018

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 16, 2018

Arjen Poutsma commented

And further commits here: 

 

Add and use AbstractDecoderTestCase

Refactor AbstractEncoderTestCase

@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants