Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract base classes for Encoder/Decoder [SPR-17449] #21981

Closed
spring-issuemaster opened this Issue Oct 31, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Oct 31, 2018

Arjen Poutsma opened SPR-17449 and commented

Recent reviews on Encoder and Decoder classes has shown that it is still too easy to make mistakes when creating them. We should add abstract base classes or helper classes that check common codec testing scenarios:

  • Encode a Flux of objects into a Flux of data buffers. Release the returned data buffers, but make sure that there are not other buffers which are still allocated.
  • Decode a Flux of data buffers into a Flux of objects. Make sure that all data buffers have been released.
  • As above, but with an error in the input stream.
  • As above, but cancel the stream after one received element.

No further details from SPR-17449

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Nov 13, 2018

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.