Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Lifecycle Callbacks section [SPR-17453] #21985

Closed
spring-issuemaster opened this Issue Oct 31, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Oct 31, 2018

Periklis Ntanasis opened SPR-17453 and commented

There is a minor error in the reference documentation, in the Initialization Callbacks and Destruction Callbacks sections.

In the Initialization Callbacks section it is mentioned:

We recommend that you do not use the InitializingBean interface, because it unnecessarily couples the code to Spring.

After that there are displayed 2 code examples. The second one uses the InitializingBean callback interface and couples the code to Spring. However, the text mentions "However, the second of the two preceding definitions does not couple the code to Spring." which is wrong. It should say the first of the two...

The same happens in the next section regarding the Destruction Callbacks.


Affects: 5.1.2

Reference URL: https://docs.spring.io/spring/docs/current/spring-framework-reference/core.html#beans-factory-lifecycle-initializingbean

Referenced from: pull request #2004

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Nov 1, 2018

Stéphane Nicoll commented

Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.