Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on @Async is confusing and biased to XML [SPR-17458] #21990

Closed
spring-issuemaster opened this Issue Nov 2, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Nov 2, 2018

Dave Syer opened SPR-17458 and commented

Look at this section of the user guide (on @Async): https://docs.spring.io/spring-framework/docs/current/spring-framework-reference/integration.html#scheduling-annotation-support-qualification. It explains how to customize the Executor but with reference to an unlinked section that is XML-based ("the 'annotation-driven' element"). It would be better just to repeat what is in the other section (or link to it) and make sure it refers to annotations.


Reference URL: spring-guides/gs-async-method#12 (comment)

Referenced from: pull request #2009, and commits 3232825

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Nov 2, 2018

Dimitrios Liapis commented

I could pick this up. I guess repeating the XML section would be clearer since I don't believe it's possible to "anchor" link on an code element.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Nov 4, 2018

Dimitrios Liapis commented

Juergen Hoeller I've created a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.