Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove java.sql dependencies from ReflectionUtils and TransactionDefinition [SPR-17464] #21996

Closed
spring-issuemaster opened this issue Nov 4, 2018 · 3 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 4, 2018

Juergen Hoeller opened SPR-17464 and commented

ReflectionUtils provides a helper for JDBC method invocations that throw java.sql.SQLException, and TransactionDefinition derives its transaction constants from java.sql.Connection. Both of those can easily be avoided in order to allow spring-core and the transaction abstraction in spring-tx to be usable on JDK 9+ images without the java.sql module present.


Issue Links:

  • #22150 Allow reuse of database error code translation without referring to JDBC module

Referenced from: commits c834790, d9c1811, 0a7dcf1

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 4, 2018

Dimitrios Liapis commented

Juergen Hoeller I could take a look at this if no-one has picked it up already.

How are we planning to replace these two invokeJdbcMethod methods? Removing them on a non-major release would break backwards compatibility, no?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 5, 2018

Juergen Hoeller commented

Dimitrios Liapis, I've prepared the first step here already: deprecating ReflectionUtils.invokeJdbcMethod in 5.1.3 and 5.0.11, ultimately removing it in 5.2. Since we're only really using it internally in WebSphereDataSourceAdapter, I've simply moved the corresponding code to a private method there.

Thanks for volunteering, in any case!

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 5, 2018

Dimitrios Liapis commented

Juergen Hoeller thanks for the details explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.