Skip to content

/ spring-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove java.sql dependencies from ReflectionUtils and TransactionDefinition [SPR-17464] #21996

Closed
spring-projects-issues opened this issue Nov 4, 2018 · 3 comments
Closed

Remove java.sql dependencies from ReflectionUtils and TransactionDefinition [SPR-17464] #21996

spring-projects-issues opened this issue Nov 4, 2018 · 3 comments
Assignees
@jhoeller
Labels
in: core in: data type: task
Milestone
5.2 M1

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Nov 4, 2018 •
edited

Juergen Hoeller opened SPR-17464 and commented

ReflectionUtils provides a helper for JDBC method invocations that throw java.sql.SQLException, and TransactionDefinition derives its transaction constants from java.sql.Connection. Both of those can easily be avoided in order to allow spring-core and the transaction abstraction in spring-tx to be usable on JDK 9+ images without the java.sql module present.

Issue Links:

  • #22150 Allow reuse of database error code translation without referring to JDBC module

Referenced from: commits c834790, d9c1811, 0a7dcf1
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 4, 2018

Dimitrios Liapis commented

Juergen Hoeller I could take a look at this if no-one has picked it up already.

How are we planning to replace these two invokeJdbcMethod methods? Removing them on a non-major release would break backwards compatibility, no?
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 5, 2018

Juergen Hoeller commented

Dimitrios Liapis, I've prepared the first step here already: deprecating ReflectionUtils.invokeJdbcMethod in 5.1.3 and 5.0.11, ultimately removing it in 5.2. Since we're only really using it internally in WebSphereDataSourceAdapter, I've simply moved the corresponding code to a private method there.

Thanks for volunteering, in any case!
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 5, 2018

Dimitrios Liapis commented

Juergen Hoeller thanks for the details explanation.
@spring-projects-issues spring-projects-issues added this to the 5.2 RC1 milestone Jan 11, 2019
Closed
@jhoeller jhoeller closed this in 80385ce Jan 28, 2019
liuming-dev added a commit to liuming-dev/compass-x that referenced this issue Jul 9, 2020
@liuming-dev
Update spring version to 5.2.7.RELEASE
21d19e3 
fix compatibility after spring version bump and update test units:
1. invokeJdbcMethod was removed from ReflectionUtils, see spring-projects/spring-framework#21996
2. queryForInt was removed from JdbcTemplate, see spring-projects/spring-framework@c1c27e7
3. org.springframework.orm.hibernate3 was removed and renamed to org.springframework.orm.hibernate5 after spring 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core in: data type: task
Projects
None yet
Milestone
5.2 M1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jhoeller @spring-projects-issues