Remove java.sql dependencies from ReflectionUtils and TransactionDefinition [SPR-17464]

[spring-issuemaster]

Juergen Hoeller opened SPR-17464 and commented

ReflectionUtils provides a helper for JDBC method invocations that throw java.sql.SQLException, and TransactionDefinition derives its transaction constants from java.sql.Connection. Both of those can easily be avoided in order to allow spring-core and the transaction abstraction in spring-tx to be usable on JDK 9+ images without the java.sql module present.

---

Issue Links:

• #22150 Allow reuse of database error code translation without referring to JDBC module

Referenced from: commits c834790, d9c1811, 0a7dcf1

[spring-issuemaster]

Dimitrios Liapis commented

Juergen Hoeller I could take a look at this if no-one has picked it up already.

How are we planning to replace these two invokeJdbcMethod methods? Removing them on a non-major release would break backwards compatibility, no?

[spring-issuemaster]

Juergen Hoeller commented

Dimitrios Liapis, I've prepared the first step here already: deprecating ReflectionUtils.invokeJdbcMethod in 5.1.3 and 5.0.11, ultimately removing it in 5.2. Since we're only really using it internally in WebSphereDataSourceAdapter, I've simply moved the corresponding code to a private method there.

Thanks for volunteering, in any case!

[spring-issuemaster]

Dimitrios Liapis commented

Juergen Hoeller thanks for the details explanation.