Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Spring Boot style flexible Duration value parsing [SPR-17481] #22013

Open
spring-projects-issues opened this issue Nov 8, 2018 · 0 comments · May be fixed by #24069
Open

Support Spring Boot style flexible Duration value parsing [SPR-17481] #22013

spring-projects-issues opened this issue Nov 8, 2018 · 0 comments · May be fixed by #24069
Labels
in: core type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Nov 8, 2018

manderson23 opened SPR-17481 and commented

Spring Boot supports specifying duration values in property files using values such as 15ms, 10s etc. (See spring-projects/spring-boot#11078).

However, this means that there are inconsistencies when trying to use the values of these properties with Spring Framework annotations. An example was provided in spring-projects/spring-boot#15126 where I would like to use a property value in a Scheduled annotation e.g.

@Scheduled(fixedRateString = "${my-prop.rate}")

In this case I have to specify the property value using java.time.Duration syntax instead of the Spring Boot flexible syntax as ScheduledAnnotationBeanPostProcessor is hardcoded to use java.time.Duration parsing.

It would be good if Spring Framework also supported the flexible syntax to allow consistent property values to be used.


Affects: 5.1.2

@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.x Backlog milestone Jan 11, 2019
ilyavy added a commit to ilyavy/spring-framework that referenced this issue Nov 25, 2019
ilyavy added a commit to ilyavy/spring-framework that referenced this issue Feb 4, 2020
dkfellows added a commit to SpiNNakerManchester/JavaSpiNNaker that referenced this issue Aug 31, 2021
This is such a dumb thing. And Spring have just sat on it for nearly 3
years, because why would you have one fundamental value parser when you
could have many?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant