Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOP support for SPR-17223 & PR#1950 [SPR-17496] #22028

Open
spring-issuemaster opened this issue Nov 15, 2018 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 15, 2018

s-mop opened SPR-17496 and commented

In previous commit at PR#1950 we supported register RequestMapping on Interface which implement in parent class.And it works well in our production environment for this 7 weks. See #21756

 

And several days ago I realized that I can't register a AOP cutpoint for the scenario.

So i tried to changed the logic of org.springframework.aop.support.AopUtils.getMostSpecificMethod(Method, Class<?>)

Now this logic will try to find specific method in targetClass's interfaces first.Instead of only do that in targetClass.

I hope this commit can make my PR more helpful;)


Affects: 5.1 GA

Reference URL: c76f017

Issue Links:

  • #21756 getMappingForMethod failed when implement a interface method(with @RequestMapping) in super class

Referenced from: pull request #1950

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 15, 2018

Juergen Hoeller commented

Alright, I'll have a look at both cases together then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.