Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardedHeaderTransformer double encodes [SPR-17525] #22057

Closed
spring-projects-issues opened this issue Nov 21, 2018 · 2 comments
Closed

ForwardedHeaderTransformer double encodes [SPR-17525] #22057

spring-projects-issues opened this issue Nov 21, 2018 · 2 comments
Assignees
Labels
in: web status: backported type: bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Nov 21, 2018

Ryosuke Hasebe opened SPR-17525 and commented

Version: 5.1.2 RELEASE

The UriComponentsBuilder encodes the already encoded query parameter again.
Please check. :)

https://github.com/spring-projects/spring-framework/blob/master/spring-web/src/main/java/org/springframework/web/server/adapter/ForwardedHeaderTransformer.java#L88


Affects: 5.1.2

Backported to: 5.0.11

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 21, 2018

Rossen Stoyanchev commented

Thanks for the report.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 21, 2018

Ryosuke Hasebe commented

Thanks.

@spring-projects-issues spring-projects-issues added type: bug status: backported in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web status: backported type: bug
Projects
None yet
Development

No branches or pull requests

2 participants