Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate JSON projection features from Spring Data [SPR-17530] #22062

Closed
spring-issuemaster opened this issue Nov 22, 2018 · 4 comments
Labels

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 22, 2018

Dave Syer opened SPR-17530 and commented

Spring Data Commons has some really cool tools for projecting JSON onto a user provided interface. The basic machinery for that is re-usable far beyond Spring Data (web endpoints, messaging, RPC, etc.), so it would be good to find it a more central home. The main abstraction is ProjectionFactory: https://github.com/spring-projects/spring-data-commons/blob/master/src/main/java/org/springframework/data/projection/ProjectionFactory.java.


Reference URL: https://github.com/spring-projects/spring-data-commons

1 votes, 6 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 22, 2018

Oliver Drotbohm commented

Happy to help moving things over. There are a couple of references to Spring Data's custom TypeInformation (a flavor of ResolvableType) but they should be replaceable with ResolvableType in general.

I guess spring-context would be the target module for the fundamental integration and spring-web for the web related parts (HttpMessageConverter etc.)? I can go ahead an create a branch in a personal Spring Framework fork and ping Rossen Stoyanchev once I have something over there.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 30, 2018

Rossen Stoyanchev commented

It's up to Juergen as far as adding this into spring-context, but is it really worth the effort and disruption to move this vs using it through spring-data-commons?

@rstoyanchev

This comment has been minimized.

Copy link
Contributor

@rstoyanchev rstoyanchev commented Jan 25, 2019

Closing but feel free to comment further.

@odrotbohm

This comment has been minimized.

Copy link
Member

@odrotbohm odrotbohm commented Jul 1, 2019

This stuff would also be incredibly helpful in Spring HATEOAS as it provides a lightweight mechanism to bind payloads in client code. Having this API integrated in Spring Framework proper would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.