Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide access to the WebScocket close status in WebFlux #22079

Open
spring-issuemaster opened this issue Nov 28, 2018 · 6 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 28, 2018

Sola opened SPR-17547 and commented

Currently, both server-side and client-side on the Reactive stack cannot get CloseStatus when the other side actively closes the connection.

the CloseStatus can be useful when the remote closes with a reasonable reason.


Affects: 5.1.3

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 28, 2018

Rossen Stoyanchev commented

Scheduling for 5.2, but for Reactor Netty we'll also need a way to get it from the WebsocketInbound. I've created reactor/reactor-netty#533.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 28, 2018

David Terk commented

Rossen Stoyanchev

Could #21790 be related to this if the server is closing the connection?

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 28, 2018

Rossen Stoyanchev commented

This ticket is for a WebSocket session. #21790 is for an HTTP POST. I don't see how they could be related.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 28, 2018

David Terk commented

Sorry Rossen Stoyanchev I missed that this was specific to WebSocket.

@unlimitedsola

This comment has been minimized.

Copy link
Contributor

@unlimitedsola unlimitedsola commented Jan 13, 2019

the original reporter here.

@rstoyanchev rstoyanchev removed their assignment Jan 28, 2019
@rstoyanchev rstoyanchev modified the milestones: 5.2 M1, 5.x Backlog Mar 19, 2019
@rstoyanchev rstoyanchev modified the milestones: 5.x Backlog, 5.3 M1 Nov 15, 2019
@rstoyanchev

This comment has been minimized.

Copy link
Contributor

@rstoyanchev rstoyanchev commented Nov 15, 2019

Looks like this is no longer blocked as of Reactor Netty 0.9.

@rstoyanchev rstoyanchev changed the title Unable to get CloseStatus when using WebSocket on Reactive stack [SPR-17547] Provide access to the WebScocket close status in WebFlux Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.