Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide access to the WebSocket close status in WebFlux #22079

Closed
spring-projects-issues opened this issue Nov 28, 2018 · 8 comments
Closed

Provide access to the WebSocket close status in WebFlux #22079

spring-projects-issues opened this issue Nov 28, 2018 · 8 comments
Assignees
Labels
in: web type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Nov 28, 2018

Sola opened SPR-17547 and commented

Currently, both server-side and client-side on the Reactive stack cannot get CloseStatus when the other side actively closes the connection.

the CloseStatus can be useful when the remote closes with a reasonable reason.


Affects: 5.1.3

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 28, 2018

Rossen Stoyanchev commented

Scheduling for 5.2, but for Reactor Netty we'll also need a way to get it from the WebsocketInbound. I've created reactor/reactor-netty#533.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 28, 2018

David Terk commented

Rossen Stoyanchev

Could #21790 be related to this if the server is closing the connection?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 28, 2018

Rossen Stoyanchev commented

This ticket is for a WebSocket session. #21790 is for an HTTP POST. I don't see how they could be related.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Nov 28, 2018

David Terk commented

Sorry Rossen Stoyanchev I missed that this was specific to WebSocket.

@spring-projects-issues spring-projects-issues added type: enhancement in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.2 RC1 milestone Jan 11, 2019
@unlimitedsola
Copy link
Contributor

@unlimitedsola unlimitedsola commented Jan 13, 2019

the original reporter here.

@rstoyanchev rstoyanchev removed their assignment Jan 28, 2019
@rstoyanchev rstoyanchev added the status: blocked label Mar 19, 2019
@rstoyanchev rstoyanchev removed this from the 5.2 M1 milestone Mar 19, 2019
@rstoyanchev rstoyanchev added this to the 5.x Backlog milestone Mar 19, 2019
@rstoyanchev rstoyanchev removed this from the 5.x Backlog milestone Nov 15, 2019
@rstoyanchev rstoyanchev added this to the 5.3 M1 milestone Nov 15, 2019
@rstoyanchev rstoyanchev removed the status: blocked label Nov 15, 2019
@rstoyanchev
Copy link
Contributor

@rstoyanchev rstoyanchev commented Nov 15, 2019

Looks like this is no longer blocked as of Reactor Netty 0.9.

@rstoyanchev rstoyanchev changed the title Unable to get CloseStatus when using WebSocket on Reactive stack [SPR-17547] Provide access to the WebScocket close status in WebFlux Nov 15, 2019
@jhoeller jhoeller changed the title Provide access to the WebScocket close status in WebFlux Provide access to the WebSocket close status in WebFlux Dec 11, 2019
@Fetsivalen
Copy link

@Fetsivalen Fetsivalen commented Apr 15, 2020

Hi,
Is anyone working on this issue?

I'd like to contribute it to the ReactorNettyWebSocketSession,
but I wonder is this ticket is about ReactorNetty's implementation only, or it is about all implementations of the WebSocketSession (not sure that each implementation will give such a possibility)?

@rstoyanchev
Copy link
Contributor

@rstoyanchev rstoyanchev commented Apr 15, 2020

ReactorNettyWebSocketSession is the starting point but we'd want to expose it on WebSocketSession since that's what an application is typically using. From there it will need to be implemented across but all other servers make this available in their API.

Short answer is yes for all implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: enhancement
Projects
None yet
Development

No branches or pull requests

4 participants