Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebFluxTags.outcome() should return OUTCOME_SUCCESS when status null [SPR-17591] #22123

Closed
spring-issuemaster opened this issue Dec 11, 2018 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Dec 11, 2018

pascal gehl opened SPR-17591 and commented

WebFluxTags.outcome() returns OUTCOME_UNKNOWN when 
exchange.getResponse().getStatusCode() returns null.
When WebFluxTags.status() assumes that the status is HttpStatus.OK in the same situation.
As a result a lot of webflux metrics are contain UNKNOWN tag.

WebFluxTags.outcome() should return OUTCOME_SUCCESS.


Affects: 5.1.3

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 12, 2018

Brian Clozel commented

WebFluxTags is a Spring Boot class, so there's nothing much to do on the Spring Framework side. If anything, we've already tackled the source of the problem in #21901 by making 200 OK the default response status. As of Spring Framework 5.1.3, you should not see null response status anymore.

You've raised this ticket against 5.1.3, does it mean you ran into such a situation? Could you reopen this issue with a sample project if you still see null response status in Spring Framework 5.1.3?

You can also raise this issue against the Spring Boot tracker, but given #21901 I don't think there's anything left to do.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.