Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for vararg message arguments in MessageSource [SPR-17600] #22132

Closed
spring-projects-issues opened this issue Dec 14, 2018 · 2 comments
Closed
Labels
in: core status: superseded

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Dec 14, 2018

Ankur Pathak opened SPR-17600 and commented

Current message arguments are passed as Object Array and it is not elegant. Since now

Spring Framework is based on Java 8. We can support Vararg based message arguments

in MessageSource by using Java 8 Interface default methods which delegates calls to

Object Array based methods. And it will be a easy to go chage as we won't have to 

implement those methods in any implementation of MessageSource.

 

I will be providing a pull request for this issue.


Affects: 5.1.3

Referenced from: pull request #2053

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Dec 14, 2018

Ankur Pathak commented

Here is pull request for the issue:

#2053

@spring-projects-issues spring-projects-issues added status: waiting-for-triage type: enhancement in: core and removed type: enhancement labels Jan 11, 2019
@rstoyanchev
Copy link
Contributor

@rstoyanchev rstoyanchev commented Mar 12, 2020

Superseded by #2053.

@rstoyanchev rstoyanchev added status: superseded and removed status: waiting-for-triage labels Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: superseded
Projects
None yet
Development

No branches or pull requests

2 participants